Add Edit Notebook Metadata to Edit menu #4333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return false; | ||
| } | ||
| callback(new_md); | ||
| }}, |
There was a problem hiding this comment.
Split }} in two lines for better readability?
|
Just two minor comments... great to have UI to notebook metadata (not only cells). |
|
yup, style comments addressed (that code was just copied/pasted from celltoolbar, I didn't look too carefully at it). |
I notice that, this is why I added the comments, because is easy to fix them now ;-) |
|
And a perfect opportunity for review - thanks for the watchful eye! |
|
|
||
| Notebook.prototype.edit_metadata = function () { | ||
| var that = this; | ||
| console.log('before', this.metadata); |
|
+1 |
ghost
assigned
|
Great, merging from my phone :-) (awesome new feature) |
Carreau
added a commit
that referenced
this pull request
Oct 6, 2013
Add Edit Notebook Metadata to Edit menu
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Add Edit Notebook Metadata to Edit menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the raw-edit dialog to IPython.dialog so it can be reused.