fix menubar height measurement

[minrk]

we were measuring the wrong divs, causing the pager splitter to occasionally be off-screen, or the top ~8 pixels of the header to be cut off (e.g. when visiting a url with an anchor).

[damianavila]

Would not be also useful to measure the toolbar_height?

Something like this:

        var toolbar_height;
        if ($('div#maintoolbar').css('display') === 'none') {
            toolbar_height = 0;
        } else {
            toolbar_height = $('div#maintoolbar'').outerHeight(true);
        }

       return h-header_height-menubar_height-toolbar_height;  // content height

[damianavila]

I mean, taking all the three elements into account to calculate the final height...

[minrk]

toolbar height is taken into account. menubar-container wraps the menubar, the toolbar, and a pad. The issues were arising because measuring the menubar and the toolbar excluded the space in between (in a weirdly inconsistent way, for some reason).

[damianavila]

OK, with your explanation, now is more clear to me, thanks.