make close-and-halt work on new tabs in Chrome #4410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the issue just that it's called in a timeout? Would it work if it was called directly in the click event? |
|
we just investigated this, and it is not an issue with the timeout. |
|
Need rebase, don't be |
.
this is not possible in Firefox, as new tabs/windows which were *not* opened via a script ( window.open call ) are not allowed to be closed via window.close and will yield a message like -- [11:50:59.691] Scripts may not close windows that were not opened by script. @ http://localhost:8888/static/notebook/js/menubar.js:105
|
Matthias Bussonnier, on 2013-10-27 04:52, wrote:
thanks for the reminder, @Carreau, rebased! there's not |
when there's ☕
ivanov
added a commit
that referenced
this pull request
Nov 1, 2013
make close-and-halt work on new tabs in Chrome
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
make close-and-halt work on new tabs in Chrome
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you open a notebook via right-click open-in-new-tab, the close-and-halt menu
item will not work. This commit fixes the issue for Chromium and IE. It is not
possible in Firefox, as new tabs/windows which were not opened via a script (
window.open call ) are not allowed to be closed via window.close and will yield
a message like: