Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't instantiate IPython shell as class attr #4413

Merged
merged 1 commit into from Oct 22, 2013
Merged

Conversation

minrk
Copy link
Member

@minrk minrk commented Oct 21, 2013

in sphinxext.ipython_directive

also fix capitalization, because reasons.

in sphinxext.ipython_directive

also fix capitalization, because reasons.
@takluyver
Copy link
Member

👍

@ivanov
Copy link
Member

ivanov commented Oct 22, 2013

👍 confirming that embedding in a documentation build now works. Merging "because reasons"!

ivanov added a commit that referenced this pull request Oct 22, 2013
don't instantiate IPython shell as class attr
@ivanov ivanov merged commit 9e82bc5 into ipython:master Oct 22, 2013
@minrk minrk deleted the sphinxext branch March 31, 2014 23:36
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
don't instantiate IPython shell as class attr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants