Allow checking for backports via milestone #4420
Conversation
| @@ -64,11 +65,11 @@ def backport_pr(branch, num, project='ipython/ipython'): | |||
| else: | |||
| req = urlopen(patch_url) | |||
| patch = req.read() | |||
|
|
|||
There was a problem hiding this comment.
We appreciate it if you can turn off whitespace stripping in your editor, because it makes reviewing changes slow. For two files, though, it's livable.
There was a problem hiding this comment.
I was surprised to see whitespace in there in the first place. I'll try to keep housekeeping commits separate in the future.
|
@minrk should have a look at this as well, since he's the most prolific user of the backport tools. |
|
OK, if you can sort out the variable naming for the iteration, I'll merge this. |
|
Don't all the API calls return json objects? Why is the milestones list different than the pulls or issues calls? |
|
Thanks, looks good to me. |
|
Thanks. The milestones list isn't any different, AIUI - the others are poorly named as well. |
Allow checking for backports via milestone
Allow checking for backports via milestone
Feel free to merge or close as you see fit. We're keeping track of backports via milestones, so I added this to some local changes.