fix js pythonisme #4425
Merged
fix js pythonisme #4425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@minrk upload should be a |
Yes, Probably. |
|
Yes, upload with name is a PUT. |
| @@ -71,7 +71,7 @@ var IPython = (function (IPython) { | |||
| reader.readAsText(f); | |||
| var name_and_ext = utils.splitext(f.name); | |||
| var nbname = name_and_ext[0]; | |||
| var file_ext = name_and_ext[-1]; | |||
| var file_ext = name_and_ext[name_and_ext.length-1]; | |||
There was a problem hiding this comment.
should just be 1, no need for length - 1
pythonnism + PUT instead of POST
|
Updated, still I think put should refuse to PUT is something is already there right ? |
|
Should it? I don't think so, that's not what the spec describes. |
|
👍 to merge as-is, since it's a relatively important feature that's just broken in master. We can work out the overwrite behavior in the future. |
|
Yes, re-read the reference rest api, and put replace if already existing. |
Carreau
added a commit
that referenced
this pull request
Oct 25, 2013
Fix impossibility to upload notebooks.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Fix impossibility to upload notebooks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But POST request is now wrong.
Investigating.