raise 404 on not found static file #4435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -322,7 +322,7 @@ def get_absolute_path(cls, roots, path): | |||
| abspath = os.path.abspath(filefind(path, roots)) | |||
| except IOError: | |||
| # empty string should always give exists=False | |||
There was a problem hiding this comment.
does this comment no longer apply then?
|
I have a better idea |
master gives 403 due to empty string being outside of root
|
Better idea was actually worse. Comment updated. |
|
Looks good. |
minrk
added a commit
that referenced
this pull request
Oct 27, 2013
raise 404 on not found static file
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
raise 404 on not found static file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
master gives 403 due to empty string being outside of root