Css cleaning

[Carreau]

Move some vbox/hbox/reverse classes from js to less (reflect changes in nbconvert html templates also)

Split notebook/style.less into 2 files app.less / style.less
second one do not contain app-specific css (like menubar, tooltip, celltoolbar).

switch import in master files style.less to import from app.less.

recompile css.

[Carreau]

Note that upgrading to less.js 1.4 and recompiling lead to a much cleaner css if we have repetitive import.
Which would again simplify our css a lot by having style.less just importing ipython.less.

[minrk]

I like moving the hbox / vbox into less classes. Are there any left, or did you get them all?

I might reverse the app/style.less logic - add a 'notebook.less' that is only the notebook structure styling, and leave style.less as everything.

I'm not sure about that, though. Do you have a preference?

[damianavila]

I like moving the hbox / vbox into less classes.

I agree...

Regarding the the app/style.less, I like the logic proposed by this PR, it seems more clear (to me) instead of a style.less as everything...

[Carreau]

I like moving the hbox / vbox into less classes. Are there any left, or did you get them all?

There is 1 or left but it is notebook-app specific the vbox that put the celltoolbar on top of the cell IIRC, but as it does not have any other class there is not much to move to less.

I can inverse style <-> app I don't have strong feeling.

[Carreau]

notebook.less already exist so i've just inverted style.less and app.less

[Carreau]

.prompt width->min-width`; mainly for nbviewer where I want hbox instead of vbox on phones.

[Carreau]

Ping ?

[minrk]

It still seems odd to me that app.less has the styling for just the notebook document when it is not the app, rather than the other way around. Other than that, everything looks good. notebook.less seems the obvious name to me, but as you pointed out that's taken. Maybe style_noapp.less?

[ellisonbg]

I will try to look at this one

Sent from my iPhone

On Nov 10, 2013, at 2:52 PM, Min RK notifications@github.com wrote:

It still seems odd to me that app.less has the styling for just the notebook document when it is not the app, rather than the other way around. Other than that, everything looks good. notebook.less seems the obvious name to me, but as you pointed out that's taken. Maybe style_noapp.less?

—
Reply to this email directly or view it on GitHub.

[Carreau]

renamed to style_noapp.less.

[Carreau]

use baseBorderRadius instead of corner_radius as it already exist in Bootstrap

[minrk]

Looks good to me now. Thanks!

[damianavila]

I don't like style_noapp name, but I don't have a better one to propose... and, at the end, it is just a name... so +1 to merge it.

[minrk]

I don't love it, but it gets the point across: this is style.less, but without the app-specific bits.
Merging away, then.