Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SVG plots in OctaveMagic by default due to lack of Ghostscript on Windows Octave #4446

Merged
merged 2 commits into from Dec 5, 2013

Conversation

blink1073
Copy link
Member

Newer builds of Octave on Windows do not include Ghostscript, and do not support printing PNG files out of the box. I suggest making the default SVG files, which is supported.

As of now, a user would have to follow the instructions here to enable support for PNGs:

http://wiki.octave.org/Octave_for_Windows#Printing_.28installing_Ghostscript.29.

@damianavila
Copy link
Member

I think the fix is reasonable... others thoughts?

@ivanov
Copy link
Member

ivanov commented Nov 26, 2013

If this is a change that only applies to windows, I'd prefer it delineate itself as such (something like if sys.platform == 'win32' set it to SVG, but keep it as PNG otherwise.

@damianavila
Copy link
Member

I agree with you...

@blink1073 can you update the PR taking into account the @ivanov's comment?

@blink1073
Copy link
Member Author

Done.

ivanov added a commit that referenced this pull request Dec 5, 2013
Use SVG plots in OctaveMagic by default due to lack of Ghostscript on Windows Octave
@ivanov ivanov merged commit 617a629 into ipython:master Dec 5, 2013
@ivanov
Copy link
Member

ivanov commented Dec 5, 2013

thanks for your contribution! eventually, we'll be moving the octave magic out of ipython proper, but hope this little change helps your fellow windows users in the meantime.

@blink1073
Copy link
Member Author

May I ask why? I am the author of oct2py.

-----Original Message-----
From: "Paul Ivanov" notifications@github.com
Sent: ‎12/‎5/‎2013 12:45 PM
To: "ipython/ipython" ipython@noreply.github.com
Cc: "Steven Silvester" steven.silvester@ieee.org
Subject: Re: [ipython] Use SVG plots in OctaveMagic by default due to lack ofGhostscript on Windows Octave (#4446)

thanks for your contribution! eventually, we'll be moving the octave magic out of ipython proper, but hope this little change helps your fellow windows users in the meantime.

Reply to this email directly or view it on GitHub.

@minrk
Copy link
Member

minrk commented Dec 5, 2013

May I ask why? I am the author of oct2py.

The point of extensions is that it is possible to add functionality to IPython from code outside IPython. It doesn't make sense for IPython to be responsible for maintaining the language extensions (cython, R, and octave are all to be removed, only R has actually been taken up elsewhere thus far), nor does it make sense to bind the extensions to IPython's release cycle.

@rossant
Copy link
Contributor

rossant commented Dec 5, 2013

Where will these language extensions be eventually?

@ivanov
Copy link
Member

ivanov commented Dec 5, 2013

in their own respective projects (the R one was already moved to rpy2, for example). Follow #3803 for more on this.

@blink1073
Copy link
Member Author

Roger, I will absorb octavemagic into oct2py following the rpy2 model.

-----Original Message-----
From: "Paul Ivanov" notifications@github.com
Sent: ‎12/‎5/‎2013 3:02 PM
To: "ipython/ipython" ipython@noreply.github.com
Cc: "Steven Silvester" steven.silvester@ieee.org
Subject: Re: [ipython] Use SVG plots in OctaveMagic by default due to lack ofGhostscript on Windows Octave (#4446)

in their own respective projects (the R one was already moved to rpy2, for example). Follow #3803 for more on this.

Reply to this email directly or view it on GitHub.

@ivanov
Copy link
Member

ivanov commented Dec 6, 2013

Thanks, Steven!

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Use SVG plots in OctaveMagic by default due to lack of Ghostscript on Windows Octave
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants