Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow JS test to run after shutdown test #4451

Merged
merged 2 commits into from Oct 31, 2013
Merged

fix: allow JS test to run after shutdown test #4451

merged 2 commits into from Oct 31, 2013

Conversation

ivanov
Copy link
Member

@ivanov ivanov commented Oct 28, 2013

shutdown notebook test closes casper browser, here we re-instatiate it after
the test

@jdfreder will need this

@ivanov
fix: allow JS test to run after shutdown test
60db9c8 
shutdown notebook test closes casper browser, here we re-instatiate it
after the test
@jdfreder
Copy link
Member

👍

@ivanov
Copy link
Member Author

ivanov commented Oct 28, 2013

did you already test it, or are you just enthusiastic with the 👍 s? ;)

@jdfreder
Copy link
Member

Overly enthusiastic, doesn't fix the problem for me. Now my shutdown_notebook.js test is crashing too. 👎

@jdfreder
Copy link
Member 

Test file: /home/jonathan/ipython/IPython/html/tests/casperjs/test_cases/shutdown_notebook.js
PASS after shutdown: no execution results
PASS after shutdown: IPython.notebook.kernel.running is false 
FAIL Error: cannot access member `evaluate' of deleted QObject
#    type: uncaughtError
#    file: /home/jonathan/ipython/IPython/html/tests/casperjs/test_cases/shutdown_notebook.js:1220
#    error: cannot access member `evaluate' of deleted QObject
#           Error: cannot access member `evaluate' of deleted QObject
#               at injectClientUtils (/home/jonathan/casperjs/modules/casper.js:1220)
#               at evaluate (/home/jonathan/casperjs/modules/casper.js:667)
#               at _step (/home/jonathan/casperjs/modules/casper.js:1753)
#               at runStep (/home/jonathan/casperjs/modules/casper.js:1521)
#               at checkStep (/home/jonathan/casperjs/modules/casper.js:372)
#    stack: not provided

@ivanov
don't delete casper instance on shutdown test
4c4050a 
a lunch conversation with @minrk and @takluyver lead me to just make a
popup and have it be closed, instead of having to reorder the test suite
so that this test always runs last. Now it doesn't matter what order the
test suite runs in, and gives us a pattern for testing window closing
behavior should we need it elsewhere.
@ivanov
Copy link
Member Author

ivanov commented Oct 29, 2013

@jdfreder check this latest fix out, that should fix the problem

@jdfreder
Copy link
Member

@ivanov I've confirmed this fixes the issue for me. Thanks 👍

@ivanov
Copy link
Member Author

ivanov commented Oct 31, 2013

merging this, so Jonathan can have it in his JS widgets test suite

ivanov added a commit that referenced this pull request Oct 31, 2013
@ivanov
Merge pull request #4451 from ivanov/shutdown-js
1afe8a5 
fix: allow JS test to run after shutdown test
@ivanov ivanov merged commit 1afe8a5 into ipython:master Oct 31, 2013
@jdfreder
Copy link
Member

Thanks Paul!

@ivanov ivanov deleted the shutdown-js branch November 5, 2013 19:43
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
@ivanov
Merge pull request ipython#4451 from ivanov/shutdown-js
2bc4ad7 
fix: allow JS test to run after shutdown test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ivanov @jdfreder