use signalstatus if exit status is undefined #4458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes failing test_exit_code_signal on OS X
| @@ -188,6 +188,13 @@ def system(self, cmd): | |||
| # We follow the subprocess pattern, returning either the exit status | |||
| # as a positive number, or the terminating signal as a negative | |||
| # number. sh returns 128+n for signals | |||
There was a problem hiding this comment.
I think we should tweak this comment a bit. Something like sh returns 128+n for signals terminating child processes on Linux; on Macs, it passes the complete exit code back to pexpect (that's my understanding of it at present).
in _process_posix
|
Alright, this is passing the tests, so I'm merging it. We can always revisit what we return in that corner case if it turns out to be problematic. |
takluyver
added a commit
that referenced
this pull request
Oct 29, 2013
use signalstatus if exit status is undefined
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
use signalstatus if exit status is undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes failing test_exit_code_signal on OS X