Python 3 & getcwdu #4469
Merged
Python 3 & getcwdu #4469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍. Looks like you got them all. |
|
After a carefull re-install + cherry-picking of the 2 commits, it works. |
minrk
added a commit
that referenced
this pull request
Nov 1, 2013
Python 3 & getcwdu We were using the os.getcwdu() function in several places. That doesn't exist on Python 3, but the path.py module was masking that by setting os.getcwdu = os.getcwd. As described in #4462, however, that didn't always work. This adds a reference in py3compat which points to getcwd on Python 3 and getcwdu in Python 2.
|
From IRC: This doesn't need to be backported, backporting #4609 appears to have been sufficient. |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Python 3 & getcwdu We were using the os.getcwdu() function in several places. That doesn't exist on Python 3, but the path.py module was masking that by setting os.getcwdu = os.getcwd. As described in ipython#4462, however, that didn't always work. This adds a reference in py3compat which points to getcwd on Python 3 and getcwdu in Python 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using the
os.getcwdu()function in several places. That doesn't exist on Python 3, but the path.py module was masking that by settingos.getcwdu = os.getcwd. As described in #4462, however, that didn't always work.This adds a reference in
py3compatwhich points to getcwd on Python 3 and getcwdu in Python 2.