Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new ipython history clear subcommand #4542

Merged
merged 13 commits into from Nov 22, 2013
Merged

Conversation

ivanov
Copy link
Member

@ivanov ivanov commented Nov 15, 2013

This new subcommand is equivalent to ipython history trim --HistoryTrim.keep=0, which is now supported (and also has a more convenient --keep alias)

This command comes with a fix to bash completion of flags for ipython history subcmd

also included is a tiny fix for nbconvert completion that was pointed out by @jakobgager in #4528

also included is a change to our utils.io.ask_yes_no function that allows for specifying the behavior of a KeyboardInterrupt.

thanks @jakobgager for pointing this out in ipython#4528
Sometimes, Ctrl-C just makes sense as an answer, and re-asking the
question is just frustrating. This changes makes it possible to break
out of the asking loop via Ctrl-C. This is particularly handy for asking
questions from the command line, where one expects Ctrl-c to be a sort
of "Cancel" operation, and is often functionally equivalent to "no"
@@ -0,0 +1,4 @@
* `ipython history trim`: added `--keep=<N>` as an alias for the more verbose
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be double backticks:

``ipython history trim``

etc.

@takluyver
Copy link
Member

Other than that, this looks good to me.

@Carreau
Copy link
Member

Carreau commented Nov 18, 2013

LGTM too.

@damianavila
Copy link
Member

I agree... OK for me too

@minrk
Copy link
Member

minrk commented Nov 22, 2013

Yay, good to merge?

@ivanov
Copy link
Member Author

ivanov commented Nov 22, 2013

👍 I'm sure I'll find other excuses to mess with bash completion later ;)

minrk added a commit that referenced this pull request Nov 22, 2013
new `ipython history clear` subcommand

This new subcommand is equivalent to ipython history trim --HistoryTrim.keep=0, which is now supported (and also has a more convenient --keep alias)

This command comes with a fix to bash completion of flags for ipython history subcmd

also included is a tiny fix for nbconvert completion that was pointed out by @jakobgager in #4528

also included is a change to our utils.io.ask_yes_no function that allows for specifying the behavior of a KeyboardInterrupt.
@minrk minrk merged commit 24e1056 into ipython:master Nov 22, 2013
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
new `ipython history clear` subcommand

This new subcommand is equivalent to ipython history trim --HistoryTrim.keep=0, which is now supported (and also has a more convenient --keep alias)

This command comes with a fix to bash completion of flags for ipython history subcmd

also included is a tiny fix for nbconvert completion that was pointed out by @jakobgager in ipython#4528

also included is a change to our utils.io.ask_yes_no function that allows for specifying the behavior of a KeyboardInterrupt.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants