New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding prompt area to non-CodeCells to indent content. #4567
Conversation
want to move the logic into all cells ? Raw included ? WIll try, but otherwise a screenshot would be good. |
I use this branch with some of my notebooks. The experience was very good with the new indentation... I really like it. But (there is always one 😉 ) I am not sure about the line to separate md from outputs of code cells, because in some places it looks ugly (at least for me) I am adding a screenshot below: As you can see, I am using little chucks of text to interconnect the code cells, trying to get a flow in the narrative. |
Yep... Having a delimiter in a vertical position as presented in the last image in less disruptive (maybe not disruptive at all) than the horizontal rule which cut the flow of information... |
The problem with the vertical line is that each part of the output would have its own line causing a lot of visual clutter. Also, the smooth hr idea is not trivial to implement without resorting to JavaScript. Not sure where to go with this one. |
But in practice you wouldn't see it. I've been working with the hline for a wek now and I don't like it.
Even with a css-before ? |
Ahh yes, using css-before it might be possible. Thoughts on the vertical line:
|
I should note that I think the smooth hr will have the same problem as the solid line. |
After tests, only if line is an actual image (or base 64 encoded), you canot do divs and alike.
That's fixable. if you know the with of the line, you pad minus this width
But red is 3 letters when you modify css live :-)
I think it's problematic with extra wide input that leak on the right. |
I quite like the right-hand-side marker in the last comment - it's subtler than putting it on the left. |
I too like the thin line on the right side. I will push commits in this PR that add that, but I am running into some CSS problems that I have started to fix in #4576 |
In that case, is it possible to get a continuous line with some On Wed, Dec 4, 2013 at 5:07 PM, Brian E. Granger
|
OK, the right, thinner, vertical, non-visually aggressive vertical line seems the way to go... I really like! |
+1 with min's comment to see how it looks. |
+1 for the right vertical line |
Consensus from dev meeting: No UI for delimiting, and see how it goes in practice. |
This is a reponse to the problem of having really long lines in Markdown cells, which makes the content difficult to read. Users want wide code cells, so we don't want to narrow everything. The solution here is to give a prompt area to the heading/md cells to narrow their content area slightly. The only problem is that this makes it more difficult to distinguish between output and md content that follows that output. The solve this, we are adding a narrow line between output and following md.
OK this is clean up and ready for merge. |
Adding prompt area to non-CodeCells to indent content. prompts now appear in the margin of the document.
Adding prompt area to non-CodeCells to indent content. prompts now appear in the margin of the document.
This is a reponse to the problem of having really long lines in Markdown cells, which makes the content difficult to read. Users want wide code cells, so we don't want to narrow everything. The solution here is to give a prompt area to the heading/md cells to narrow their content area slightly. The only problem is that this makes it more difficult to distinguish between output and md content that follows that output. The solve this, we are adding a narrow line between output and following md.
This is a continuation of #4155 that removes the other stuff that wasn't ready for review/merge. I am going to close #4155.