make sure to encode URL components for API requests #4575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
like url_path_join, but escapes url components
| this.notebook_name = json.name | ||
| var name = this.notebook_name | ||
| var path = json.path | ||
| console.log(json); |
notebook names can have spaces, hashes, other special characters.
|
+1 |
send arguments on failed events
|
Finally got around to adding the test. Should be ready for a review now. |
|
👍 |
minrk
added a commit
that referenced
this pull request
Dec 19, 2013
make sure to encode URL components for API requests
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
make sure to encode URL components for API requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both notebook name and path can have spaces, hashes, other special characters. Most common characters didn't cause problems, but hashes certainly did.
This shouldn't be merged until I work out a test for it.
closes #4574
closes #4620