Fix nbrun in notebooks with non-code cells. #4634
Merged
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
definitely the right thing to do, thanks. Can you add a test (or add non-code cells to an existing test notebook)? |
|
I fix the test to include a text cell, let me know if it is enough... |
|
Travis is failing but not in core... probably not related with this PR... but who knows? 😉 |
|
travis looks fine now. |
minrk
added a commit
that referenced
this pull request
Dec 4, 2013
Fix nbrun in notebooks with non-code cells.
|
Just for reference, I realized the problem writing this post: http://www.damian.oquanta.info/posts/dont-write-scripts-just-write-ipyscripts.html |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Fix nbrun in notebooks with non-code cells.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you try to run notebooks with the
runmagic:% run my_notebook.ipynbif the notebook contains non-code cells, it fails...
So I made a little fix to filter the code cells from the notebook passed as argument.