Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor import fix to get qtconsole with --pylab=qt working #4639

Merged
merged 1 commit into from Dec 4, 2013
Merged

Minor import fix to get qtconsole with --pylab=qt working #4639

merged 1 commit into from Dec 4, 2013

Conversation

punchagan
Copy link
Contributor

Running the qtconsole with --pylab=qt on non-OSX-10.9 OSes fails with
the error TypeError: 'NoOpContext' object is not callable.

Running the qtconsole with --pylab=qt on non-OSX-10.9 OSes fails with
the error `TypeError: 'NoOpContext' object is not callable`.
@punchagan punchagan mentioned this pull request Dec 4, 2013
@Carreau
Copy link
Member

Carreau commented Dec 4, 2013

would'nt it be better that nope_scope was NoOpContext directly in app_nope (in the right cases) ? @minrk ?

@minrk
Copy link
Member

minrk commented Dec 4, 2013

@Carreau it already is, but appnope doesn't know about the flag that is also used in the decision. This change is still the right thing to do.

minrk added a commit that referenced this pull request Dec 4, 2013
Minor import fix to get --pylab=qt working again on OS X
@minrk minrk merged commit b5927e7 into ipython:master Dec 4, 2013
@Carreau
Copy link
Member

Carreau commented Dec 5, 2013

doesn't know about the flag that is also used in the decision

Ah yes, I missed the kernel._darwin_app_nap; the if _on_os_x_10_9() feel like it belongs in app-nope though.

@ghost ghost assigned minrk Dec 24, 2013
minrk added a commit that referenced this pull request Dec 24, 2013
…working

Running the qtconsole with --pylab=qt on non-OSX-10.9 OSes fails with
the error `TypeError: 'NoOpContext' object is not callable`.
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Minor import fix to get --pylab=qt working again on OS X
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants