Allow docs to build without PyQt installed. #4642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyQt/PySide is needed to list the config options for the Qt console. But some environments and contributors may not have it, and it's not always easy to install. This prints a warning and skips the list of Qt console options if the import fails.
|
Looks good to me... and it is an improvement because it is not so simple to install PyQt in a virtualenv (ok, it is easy after you know how to do it 😉 ) |
|
How do you do it? I don't know that! ;) |
|
I have a postmkvirtualenv script containing the following: http://linkode.org/eSszlSzx8zAIWD0L1P8Nw4 |
|
+1 |
|
Ah, I see, so it has to be installed systemwide already. Anyway, merging this. |
takluyver
added a commit
that referenced
this pull request
Dec 5, 2013
Allow docs to build without PyQt installed.
Yep! |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Allow docs to build without PyQt installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyQt/PySide is needed to list the config options for the Qt console. But some environments and contributors may not have it, and it's not always easy to install. This prints a warning and skips the list of Qt console options if the import fails.