Stop bundling the numpydoc Sphinx extension #4670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numpydoc is now a separately installable package, so we can express a dependency for the 'doc' install option, rather than bundling it. This gets us bugfixes that our copy was lacking - one of which was causing a problem for the ShiningPanda docs job.
| @@ -275,7 +275,7 @@ def run(self): | |||
| parallel = 'pyzmq>=2.1.11', | |||
| qtconsole = ['pyzmq>=2.1.11', 'pygments'], | |||
| zmq = 'pyzmq>=2.1.11', | |||
| doc = 'Sphinx>=0.3', | |||
| doc = ['Sphinx>=0.3', 'numpydoc'], | |||
There was a problem hiding this comment.
want to bump this to 1.0, or just leave it as 'Sphinx'? Is there any risk of Sphinx 0.2.x out there?
|
👍 |
|
Good idea, 👍 |
|
Merging then. |
Carreau
added a commit
that referenced
this pull request
Dec 11, 2013
Stop bundling the numpydoc Sphinx extension numpydoc is now a separately installable package, so we can express a dependency for the 'doc' install option, rather than bundling it. This gets us bugfixes that our copy was lacking - one of which was causing a problem for the ShiningPanda docs job.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Stop bundling the numpydoc Sphinx extension numpydoc is now a separately installable package, so we can express a dependency for the 'doc' install option, rather than bundling it. This gets us bugfixes that our copy was lacking - one of which was causing a problem for the ShiningPanda docs job.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numpydoc is now a separately installable package, so we can express a dependency for the 'doc' install option, rather than bundling it. This gets us bugfixes that our copy was lacking - one of which was causing a problem for the ShiningPanda docs job.