Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use if main block in entry points #4700

Merged
merged 2 commits into from Dec 17, 2013
Merged

use if main block in entry points #4700

merged 2 commits into from Dec 17, 2013

Conversation

minrk
Copy link
Member

@minrk minrk commented Dec 15, 2013

closes #4698

@minrk minrk mentioned this pull request Dec 15, 2013
Closed
@rkern
Copy link
Contributor

rkern commented Dec 16, 2013

I suggest moving the import under the if test, too, but it's not critical. LGTM.

@minrk
Copy link
Member Author

minrk commented Dec 17, 2013

@rkern done, thanks.

minrk added a commit that referenced this pull request Dec 17, 2013
@minrk
Merge pull request #4700 from minrk/ifmain
7af5ec3 
use if main block in entry points
@minrk minrk merged commit 7af5ec3 into ipython:master Dec 17, 2013
@minrk minrk deleted the ifmain branch December 17, 2013 19:04
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
@minrk
Merge pull request ipython#4700 from minrk/ifmain
84877a2 
use if main block in entry points
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

Missing "if __name__ == '__main__':" check in /usr/bin/ipython
2 participants
@minrk @rkern