Math macro in jinja templates. #4703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, I alway like commits that do the same with less line of code. |
|
Somebody else? |
|
And in this one... any other comment? |
|
needs rebase. My only comment is that it seems like the mathjax macro template should be called mathjax, not math. |
|
Rebased and changes done accordingly with @minrk comments... |
minrk
added a commit
that referenced
this pull request
Jan 13, 2014
Mathjax macro in jinja HTML templates.
|
Thanks! |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Mathjax macro in jinja HTML templates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the aim of reuse code, I have written a mathjax jinja macro living inside math.tpl.
In this way, the two templates html_full and slides_reveal (an any other) can call this macro (a sort a function) using the
{{ mathjax() }}after importing the macro.