Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove irunner, iplogger #4706

Merged
merged 3 commits into from Dec 16, 2013
Merged

remove irunner, iplogger #4706

merged 3 commits into from Dec 16, 2013

Conversation

minrk
Copy link
Member

@minrk minrk commented Dec 16, 2013

and mkdoctests, which was the only user of irunner

@takluyver
Copy link
Member

Is it worth doing a deprecation cycle - i.e. removing the irunner script but leaving the module in place, possibly with a deprecation warning on import, for another cycle, just to soften the blow a bit for anyone who is still using it.

The test failures are because you removed the module and left the tests in place ;-)

@minrk
Copy link
Member Author

minrk commented Dec 16, 2013

I removed them, I just failed to push. Should be there now.

takluyver added a commit that referenced this pull request Dec 16, 2013
remove irunner, iplogger
@takluyver takluyver merged commit 9a88a54 into ipython:master Dec 16, 2013
@Carreau
Copy link
Member

Carreau commented Dec 17, 2013

Is it worth doing a deprecation cycle - i.e. removing the irunner script but leaving the module in place, possibly with a deprecation warning on import, for another cycle, just to soften the blow a bit for anyone who is still using it.

I guess this was discussed internally :-)

@takluyver
Copy link
Member

Yep, I asked Min and Paul about it, and the consensus was that we're not likely to revive it anyway, and we have no evidence that anyone is actually using it.

@minrk minrk deleted the irunner branch December 17, 2013 18:52
@juliantaylor
Copy link
Contributor

why is irunner removed?
I use it regulary, its incredibly useful to benchmark C extensions :(

@takluyver
Copy link
Member

Told you we'd find someone who uses it ;-)

@takluyver
Copy link
Member

More seriously: @juliantaylor , what do you do with irunner to test C extensions that can't be done with a normal .py script, or a .ipy script if the need arises?

@juliantaylor
Copy link
Contributor

usually just %timeit stuff and then running it under a profiler (e..g perf), quick and convenient
it can also be done with .ipy scripts, I forgot about these, so I guess I can live without irunner.

minrk added a commit to minrk/ipython that referenced this pull request Jan 7, 2014
the scripts were removed in ipython#4706, but not their manpages
@juliantaylor
Copy link
Contributor

now that irunner is gone a while I notice it a lot more that its missing.
I more often than I though just run regular python files with irunner to get the repr output or something nice to paste.

So I must ask again as I didn't get an answer last time why was it removed? Is it hard to maintain?
It was working fine for me in with regular updated git head up until it was removed.
If its not a maintenance burden maybe a little census on the mailing list could be done? be it just to show that I'm weird ;)

@takluyver
Copy link
Member

I don't think it was especially hard to maintain, but none of us knew of any good reason to use it, we've not advertised its existence for years, and we're trying to reduce the number of scripts we install (PyColorize went away for a similar reason). We saw it as trimming dead weight, I think.

Feel free to ask on the mailing list, but given that no-one else has complained about its removal so far, I doubt there were many people using it.

I'm still not quite clear on what you were using it for, to be honest.

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
the scripts were removed in ipython#4706, but not their manpages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants