Fix indent and center #4708
Fix indent and center #4708
Conversation
|
Will read more carefully but at first glance null.tplx should be regenerated and test fails. |
|
Yep, not ready for review yet... I did some things too much complicated... I will work on this in a couple of hours... |
|
@Carreau simplified approach, test passed, and ready for review! |
| {% block e_in_prompt -%} | ||
| <div class="prompt input_prompt"> | ||
| </div> | ||
| {%- endblock e_in_prompt %} |
There was a problem hiding this comment.
and what would be the meaning of e_ it would nice to be more explicit.
There was a problem hiding this comment.
e is for empty... I try to make it short but I can change it if you want...
There was a problem hiding this comment.
Yes, I would prefer something more explicit. I'm searching for a better name, but can't find.
There was a problem hiding this comment.
ok, think a little bit... if nobody come up with a better name (including me 😉) by tomorrow, I will change it to empty_in_prompt to make it more explicit...
|
Changed the name to of empty prompt to a more explicit one: |
|
Any other comments? |
|
People, any more comments on this? |
ghost
assigned 
| displayAlign: 'left', // Change this to 'center' to center equations. | ||
| // Center justify equations in code and markdown cells. Elsewhere | ||
| // we use CSS to left justify single line equations in code cells. | ||
| displayAlign: 'center', | ||
| "HTML-CSS": { |
There was a problem hiding this comment.
While you are at this, can you audit the other MathJax config things to make sure nbconvert is tracking what is in the live notebook. For example, we also now set linebreaks: { automatic: true } inside the HTML-CSS section. Might as well update all that while we are touching this code.
There was a problem hiding this comment.
OK, I will do it tomorrow morning... it's late here ;-)
|
OK, rebased (there was a lot of changes in html template lately) and @ellisonbg's comments addressed... ready for a re-review 😉 |
|
@ellisonbg , this is still assigned to you - do you think it needs any more review before it's merged? |
|
Let me double check to see how it looks. On Fri, Jan 24, 2014 at 11:31 AM, Thomas Kluyver
Brian E. Granger |
|
Looks good, merging. |
|
Thanks! |
Fix indent and center
Some weeks ago they were merged two PR changing some UI things: #4154 and #4567.
These PR bring some changes in the centring of equations and indentation of non code cells.
This PR takes into account this changes and translate it to
nbconvert.Here is the screenshot of current
html_fullfromnbconvert:And this one is the new look proposed by this PR, which follow the last changes in the notebook appearance:
I have also regenerated the
null.tplxbecause it was not updated (missing a lower() in the raw cell block).Now, I think is ready for review.