add some HTML error pages #4735
Conversation
catches import / key errors and turns them into proper http errors
| try: | ||
| from IPython.nbconvert.exporters.export import exporter_map | ||
| except ImportError: | ||
| exporter_map = {} |
There was a problem hiding this comment.
Won't this mask real errors importing that module?
There was a problem hiding this comment.
It should mask them - you can't start the notebook server right now without nbconvert's dependencies.
There was a problem hiding this comment.
Or rather, there should be a log message, but no error.
There was a problem hiding this comment.
Possibly the try/except should be happening where the exporter_map is populated, though, so that if dependencies for one part of nbconvert are missing, other exporters are still available. It would also be nice to tell the user what's missing when they try to export to a given format, rather than logging the information when the server starts.
ensures things are always importable, and delays ImportErrors until they are actually relevant.
same treatment as pygments in previous commit
pygments is the only such example at this time
|
I think I addressed @takluyver's review thus far. Now, when nbconvert fails due to missing dependencies, you get an informative error. |
| {% if message %} | ||
| <p>The error was:</p> | ||
| <div class="traceback-wrapper"> | ||
| <pre class="traceback">{{message | replace('\n', '<br/>')}}</pre> |
There was a problem hiding this comment.
Is this replacement required? I thought line breaks inside pre tags were displayed anyway.
There was a problem hiding this comment.
No, this doesn't make sense - I think I was using a div tag when I added the replacement, and just forgot to remove it. Removed now.
|
👍 |
relic from when I was using div, not pre
add some HTML error pages
Among other things, this should allow users to see what happened when nbconvert fails.
CSS could probably use some love, but it's a starting point.