check every link when detecting virutalenv #4737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
minrk
commented
Dec 23, 2013
minrk
commented
- can't use just sys.executable, because the env python can be a link target
- can't use realpath, because the env python can be a link to outside the env
- can't use just sys.executable, because the env python can be a link target - can't use realpath, because the env python can be a link to outside the env
|
Looks OK. Have you actually run into the problem, so you can check that this fix works? |
|
Yes - prompted when using Python 3.4b1 with stdlib venv, where sys.executable is a symlink to the original python executable, rather than a patched binary. |
takluyver
added a commit
that referenced
this pull request
Dec 26, 2013
check every link when detecting virutalenv
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
check every link when detecting virutalenv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.