don't use lazily-evaluated rc.ids in wait_for_idle #4744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can cause KeyError in parallel tests same fix in 69b0a18
|
looks ok. |
takluyver
added a commit
that referenced
this pull request
Dec 27, 2013
don't use lazily-evaluated rc.ids in wait_for_idle
|
Thanks Min. |
minrk
added a commit
to minrk/ipython
that referenced
this pull request
Dec 28, 2013
jdfreder
pushed a commit
to jdfreder/ipython
that referenced
this pull request
Jan 2, 2014
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
don't use lazily-evaluated rc.ids in wait_for_idle
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can cause KeyError in parallel tests
finish up fix started in 69b0a18
Should address some intermittent failures seen by Shining Panda