Qt console: Fix _prompt_pos accounting on timer flush output. #4768
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When output is appended to the frontend widget by the output
flushing timer, the
_prompt_pos
was not being modified accordingly.This could cause incorrect prompt position resulting in apparent
freezing of the prompt in some circumstances.
Running the following file and then doing
p.edit_traits()
a coupleof times in the frontend and clicking the button shows the error
some times, when the prompt stops responding to
enter
andbackspace
once the prompt pos exceeds the document's size.I would also like this to be backported into
1.x
branch, but i'm not sure of the procedure.