Don't wait forever for notebook server to launch/die for tests #4773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should turn occasional hangs into straightforward errors.
|
|
||
| @classmethod | ||
| def wait_until_dead(cls): | ||
| """Wait for the server to stop getting requests after shutdown""" | ||
| url = 'http://localhost:%i/api/notebooks' % cls.port | ||
| while True: | ||
| for _ in range(300): |
There was a problem hiding this comment.
this one can just wait until notebook.poll() is not None, right?
There was a problem hiding this comment.
Yep, I've simplified it now.
|
in general, I'd say it's good practice to avoid having bare naked constants in code like the 300 used twice here without a name or an explanation. If you just add a MAX_WAITTIME = 30 # seconds to wait for notebook server to start
POLL_INTERVAL = 0.1 # time between attemptsThen you can changes your for loops to be But since this is just test code, I'm not too bothered by it. |
|
otherwise 👍 |
| @@ -52,6 +55,7 @@ def setup_class(cls): | |||
| sys.executable, '-c', | |||
| 'from IPython.html.notebookapp import launch_new_instance; launch_new_instance()', | |||
| '--port=%d' % cls.port, | |||
| '--port-retries=0', | |||
There was a problem hiding this comment.
is this "don't retry" or "retry indefinitely"
There was a problem hiding this comment.
the first - it is "retry zero times"
|
Thanks for clarifying the code, Paul ;-) |
ivanov
added a commit
that referenced
this pull request
Jan 9, 2014
Don't wait forever for notebook server to launch/die for tests
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Don't wait forever for notebook server to launch/die for tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should turn occasional test hangs (e.g. https://s3.amazonaws.com/archive.travis-ci.org/jobs/16615179/log.txt ) into straightforward errors.