New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warn when notebook is started in pylab mode #4788
Conversation
self.log.warn('\n '.join([ | ||
"Starting all kernels in pylab mode is not recommended.", | ||
"Please use the %matplotlib magic to enable matplotlib instead.", | ||
"The imports `--pylab` makes can have confusing side effects", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes can
? does this construction make sense in /English?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does make sense, but I'll try to word it a little better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :-)
because it is always a bad idea
How about "Please use |
I'm not sure I would even recommend using |
Plus, I am hoping to remove support for specifying kernel flags at the server command-line, which would disable |
OK, it is more clear to me now...
I totally agree... |
+1 , I would have been even more annoying by asking the user : BTW, can we have colors in |
"Starting all kernels in pylab mode is not recommended.", | ||
"Please use the %matplotlib magic to enable matplotlib instead.", | ||
"pylab implies many imports, which can have confusing side effects", | ||
"and harm the reproducibility of your notebooks.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a note that this will be deprecated
warn when notebook is started in pylab mode
warn when notebook is started in pylab mode
because it is always a bad idea
Hopefully we will actually deprecate specifying kernel args at notebook launch, but that won't be for a while. Warning about the most harmful and common option seems like a good compromise.