merge reveal templates #4795
merge reveal templates #4795
Conversation
there was very fine-grained subclassing in reveal_internals, which I don't think was beneficial.
|
I will test it in depth tomorrow morning (late here now)... I think it would not be any problem... |
| {% from 'mathjax.tpl' import mathjax %} | ||
|
|
||
| {%- block any_cell scoped -%} | ||
| {%- if cell.metadata.slide_type in ['-'] -%} |
There was a problem hiding this comment.
I would like to see this "do nothing cell" ['-'] after the subslides (I mean after the 13th line of the code)... I know that the current implementation is totally valid... but I think that putting it after the subslides is a conceptual enhancement because the new developer will have an immediate idea of the overall structure: slide>subslides and then intraslides properties such as: "-", skip, notes and fragments.
|
I just did one comment with a minor change I think is important... otherwise it is OK for me... (I also tested and it did not present any problem...) |
|
reordered, thanks @damianavila |
|
Thanks to you for the reordering... |
merge reveal templates
there was very fine-grained subclassing in reveal_internals in four template files, which I don't think was beneficial.
Ping @damianavila for review, in case this separation was used in ways I am not aware of.