New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some $.html( -> $.text( #4826
some $.html( -> $.text( #4826
Conversation
Thoses that are obvious and easy to fix. we shoudl have I think a travis test that grep for .html( and return less than 20 lines :-)
@ivanov, you are the King on casper test. Is this the right way ? |
:-( test are supposed to fail for once. but they don't. |
sent you a PR to make them fail, Matthias (just a minor typo) 🍻 |
make the JS test fail
Travis should be angry soon, then I fix the injection in prompt :-) |
Looks, good, anything else before merging? |
No, I'll do more step by step in small PR when I get time. Unlike you I'm not used to have more than 5 PR in parallel :-) |
some $.html( -> $.text(
Thoses that are obvious and easy to fix.
we shoudl have I think a travis test that grep for .html( and return
less than 20 lines :-)
One more fix is
html('×')
tohtml('×')
(add semicolon).Havent check manually each place in UI.