Add Origin Checking. #4845
Merged
Add Origin Checking. #4845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # Check to see that origin matches host directly, including ports | ||
| if origin != host: | ||
| self.log.critical("Cross Origin WebSocket Attempt.", exc_info=True) |
There was a problem hiding this comment.
Probably don't need exc_info=True, since there is no exception
| @@ -17,6 +17,11 @@ | |||
| #----------------------------------------------------------------------------- | |||
|
|
|||
| try: | |||
| from urllib.parse import urlparse | |||
There was a problem hiding this comment.
I'd add a comment here indicating this is the py3 codepath. That way we'll know in the future and when we drop py2 compatibility, we can remove the py2 path.
| origin = parsed_origin.netloc | ||
|
|
||
| # Check to see that origin matches host directly, including ports | ||
| if origin != host: |
There was a problem hiding this comment.
just need to check that Host and Origin are both affected in the same way by proxies / tunnels
| def check_origin(self): | ||
| """Check origin from headers.""" | ||
| origin_header = self.request.headers["Origin"] | ||
| host = self.request.headers["Host"] |
There was a problem hiding this comment.
Probably use get, in the unlikely event these are undefined.
|
You mentioned moving the check to on_open in authenticated handler, did you still want to do that? |
|
Yeah, I'll override open. |
ghost
assigned 
|
AFAIK, LGTM 😉 |
minrk
added a commit
that referenced
this pull request
Jan 31, 2014
Add Origin checking for websockets.
minrk
added a commit
that referenced
this pull request
Jan 31, 2014
pankajp
pushed a commit
to pankajp/ipython
that referenced
this pull request
Feb 19, 2014
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Add Origin checking for websockets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This verifies that requests originate from the same host that a notebook is run on.