Remove some leftover traces of irunner #4846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| :mod:`IPython.external`, but if you have installed pexpect, IPython will use | ||
| The pexpect_ package is used | ||
| for managing subprocesses. IPython now includes a version of Pexpect in | ||
| :mod:`IPython.external`, but if you have installed Pexpect, IPython will use | ||
| that instead. On Unix platforms (including OS X), just do: | ||
|
|
||
| .. code-block:: bash | ||
|
|
||
| $ pip install pexpect |
There was a problem hiding this comment.
not really part of this PR, but while we're here, is there a reason we tell users that
- we use pexpect
- we ship a version of pexpect in external
- we use installed version of Pexpect of one exists
- here's how to install pexect.
It seems to me that we Should get rid of 4, and reorder the others to be to go: 1,3,2, no?
|
other than that, I'm 👍 here |
|
I've removed the section on Pexpect and added a sentence about IPython.external |
|
Sweet, thanks Thomas! The RTD link for Pexpect is so much nicer to read than that retro green-on-black noah.org link. Merging! |
ivanov
added a commit
that referenced
this pull request
Jan 23, 2014
Remove some leftover traces of irunner
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Remove some leftover traces of irunner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was still referenced in some docs and setup scripts.