New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add js kernel_info request #4847
Conversation
Can't the kernel only answer the info request when it's not busy? So it dosen't make much sense to have the idle/busy status in the reply. |
Right - it makes no sense for kernel_info_reply to include status, because if there is a reply, the status is idle. So you could do it that way - start the status as busy, and then set it to idle when you get the kernel reply. |
Is that obviously true for non-python kernel ? Couldn't you have a kernel that is able to treat But agreed for Python kernel. Will update other PR. Does this prevent the addition of this utility function to the javascript ? |
Not at all. If you add a test, I think this is ready to merge. |
Should be tested to at least return a dict. Envoyé de mon iPhone
|
@@ -0,0 +1,28 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe rename to kernel_info.js?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well I hope it will contain other kernel tests at some point ... But I can.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It just seems weird to have js in the name, so I would remove that at least, and leave it as kernel.js or kernel_test,js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It just seems weird to have js in the name, so I would remove that at least, and leave it as kernel.js or kernel_test,js
Done as soon as git push achieve to go through my connection.
Thanks. |
add js kernel_info request
I would have hopped it to respond also with a "Kernel Idle".
Would it make sens/is it possible to add the (optional) "status" field to
kernel_info_reply
?