fix tb_offset when running a file #4858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
about not overriding execfile on 2.x because we do override it
either with %run or via `ipython script.py` since we wrap execfile, the tb_offset needs to be 2 instead of the default (1). closes ipython#4835
|
Do you think it's worth adding a test? I can only think it would be a hackish text-munging type of test, but this is the sort of thing that's liable to break again. |
|
I would love to add a test, but one didn't stand out to me. I'll try to work one out. |
|
tests added |
|
And passing. Merging. |
takluyver
added a commit
that referenced
this pull request
Jan 24, 2014
fix tb_offset when running a file
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
fix tb_offset when running a file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
either with %run or via
ipython script.pysince we wrap execfile, the tb_offset needs to be 2 instead of the default (1).
closes #4835