Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URL for Lawrence Hall of Science webcam image #4867

Merged
merged 1 commit into from Jan 25, 2014

Conversation

takluyver
Copy link
Member

Closes gh-4752

I also reran the notebook in order, so all the prompt numbers have changed.

@Carreau
Copy link
Member

Carreau commented Jan 24, 2014

The second video (embeded base64) is broken on nbviewer.
Can you move the External File Section to use from IPython.display import IFrame?

I think a cell that emphasis that if you have something after Image() in a cell, display hook will not trigger.
an example with None or pass ? What do you think ?


Since when does Filelinks list directory recursively ?

Closes ipythongh-4752

I also reran the notebook in order, so all the prompt numbers have
changed.

Also, update example to use IFrame class, and fix embedded video on Py 3
@takluyver
Copy link
Member Author

  • Fixed the video (it was a Python 3 issue), and squashed the commits to avoid a change on the huge base64 line.
  • Use IFrame instead of HTML with a manually defined iframe tag.

The description for Filelinks in this notebook actually says it operates recursively, but last time we ran this, we had nothing for it to recurse into.

I agree that explaining a bit about displayhook and the display function makes sense, but let's deal with that in a separate PR.

Carreau added a commit that referenced this pull request Jan 25, 2014
Update URL for Lawrence Hall of Science webcam image
@Carreau Carreau merged commit 24bd777 into ipython:master Jan 25, 2014
@Carreau
Copy link
Member

Carreau commented Jan 25, 2014

Great ! merged !

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Update URL for Lawrence Hall of Science webcam image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

link broken in docs/examples
2 participants