Static path fixes #4868
Merged
Static path fixes #4868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allows packages to run the tests during package build and install time where the two file locations might be split.
get_ipython_package_dir() does not necessarily contain the files, e.g. in distribution packages which share files with python3 in a different folder.
|
Looks good, thanks. |
minrk
added a commit
that referenced
this pull request
Jan 25, 2014
more use of the package dir instead of static file dir, and update a previous test patch of mine to work for build and install time tests
pankajp
pushed a commit
to pankajp/ipython
that referenced
this pull request
Feb 19, 2014
more use of the package dir instead of static file dir, and update a previous test patch of mine to work for build and install time tests
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Static path fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more use of the package dir instead of static file dir, and update a previous test patch of mine to work for build and install time tests