better cleanup channel FDs #4890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use ioloop.close(all_fds=True) - ensure socket is closed - no longer need override of stop in any Channel subclass
avoids leaking FDs
|
This fixes my issue on Python 2.x, but it looks like it's failing on Python 3.x on Travis. |
|
Thanks for the quick fix! |
|
I also meant to say: I ran your test all the way to 1000 kernels, so this should be okay. The failure is in javascript tests, so not related to this, but I restarted travis anyway it anyway. |
|
Looks good, I am +1 on merging. |
|
And Travis has given it the green light now. |
|
Tests passing, code looks good, merging. |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
better cleanup channel FDs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4882