use importlib.machinery when available #4928
Merged
+9
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import inspect | ||
| import os | ||
| import re | ||
| import sys | ||
|
|
||
| try: |
There was a problem hiding this comment.
Do we want some comments here for which versions of Python take which paths?
There was a problem hiding this comment.
This comment should mention Python >=3.3, not just 3, since e.g. 3.2 does not have importlib.machinery.all_suffixes.
avoids deprecation warning on startup, and allows tests to pass with PYTHONWARNINGS=d closes ipython#4051 candidate for backport to 1.2
takluyver
added a commit
that referenced
this pull request
Jan 29, 2014
use importlib.machinery when available
takluyver
added a commit
that referenced
this pull request
Jan 29, 2014
|
Backported |
|
You forgot to change |
takluyver
added a commit
that referenced
this pull request
Jan 29, 2014
|
Oops, thanks @Arfrever. Should be fixed now. |
pankajp
pushed a commit
to pankajp/ipython
that referenced
this pull request
Feb 19, 2014
pankajp
pushed a commit
to pankajp/ipython
that referenced
this pull request
Feb 19, 2014
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
use importlib.machinery when available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoids deprecation warning on startup, and allows tests to pass with
PYTHONWARNINGS=d
closes #4051
candidate for backport to 1.2