Ignore sys.argv for NotebookNotary in tests #4966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thinking about it some more, I feel like there's something wrong with the abstraction here - NotebookNotary shouldn't be trying to find or create an Application instance. @minrk , let's have a chat about this when you get in. |
|
I probably shouldn't be creating an Application, but it's a pain to create ProfileDir objects, handling all of the cases of whether directories exist, etc., and this is exactly what BaseIPythonApp does. I will have a go at improving ProfileDir creation later, but this fix should be fine for now. |
minrk
added a commit
that referenced
this pull request
Jan 31, 2014
Ignore sys.argv in NotebookNotary when creating a BaseIPythonApplication just for its profile_dir
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Ignore sys.argv in NotebookNotary when creating a BaseIPythonApplication just for its profile_dir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing failures on SP because BaseIPythonApplication was trying to parse nose flags like
--with-xunit.