Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin lessc to 1.4 #5027

Merged
merged 1 commit into from Feb 4, 2014
Merged

pin lessc to 1.4 #5027

merged 1 commit into from Feb 4, 2014

Conversation

minrk
Copy link
Member

@minrk minrk commented Feb 4, 2014

Not necessarily what we want to do, but every minor revision of less seems to change how it minifies, which produces churn in supposedly small changes.

At least this should prevent accidental churn, as has recently been committed to master.

My vague plan has been to update less when we switch to bootstrap 3, since that will certainly make big changes to the css product anyway.

Not necessarily what we want to do,
but every minor revision of less seems to change how it minifies,
which produces churn.

At least this should prevent accidental churn,
as has recently been committed to master.
@ellisonbg
Copy link
Member

Great, I will try this out and use it to help me get the right version of less...

@ellisonbg ellisonbg added this to the 2.0 milestone Feb 4, 2014
@ellisonbg
Copy link
Member

This looks great, merging.

ellisonbg added a commit that referenced this pull request Feb 4, 2014
@ellisonbg ellisonbg merged commit 7b8c066 into ipython:master Feb 4, 2014
@minrk
Copy link
Member Author

minrk commented Feb 4, 2014

I could have added a note for how to install a pinned version:

npm install -g less@1.4.2

@minrk minrk deleted the pin-less branch February 4, 2014 23:55
@ellisonbg
Copy link
Member

That might be a good idea.

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants