Remove duplicated Channel ABC classes. #5042
Merged
+1
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were moved to IPython.kernel.channelsabc, but the old copies were retained somehow. Should we import them back into managerabc for backwards compatibility if third party code has imported them from there? It seems unlikely that they'd be used outside our codebase.
|
There's no reason for anyone to do that, might as well remove them. |
|
will merge as soon as travis shows green. |
minrk
added a commit
that referenced
this pull request
Feb 6, 2014
Remove duplicated Channel ABC classes.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
…icates Remove duplicated Channel ABC classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were moved to IPython.kernel.channelsabc, but the old copies were retained somehow.
Should we import them back into managerabc for backwards compatibility if third party code has imported them from there? It seems unlikely that they'd be used outside our codebase.