Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

another pass on Interact example notebooks #5063

Merged
merged 2 commits into from Feb 7, 2014
Merged

Conversation

minrk
Copy link
Member

@minrk minrk commented Feb 7, 2014

forgot to check Lorenz before merging the interact PR

and change the w.kwargs example in Interact to one without image data

forgot to check Lorenz before merging the interact PR

and change the w.kwargs example in Interact to one without image data
@takluyver
Copy link
Member

GH doesn't show diffs for these, and reviewing notebook diffs is a pain anyway. I'm just going to merge this, and make further PRs for anything I think should change.

takluyver added a commit that referenced this pull request Feb 7, 2014
another pass on Interact example notebooks
@takluyver takluyver merged commit c538b26 into ipython:master Feb 7, 2014
@minrk minrk deleted the lorenz branch March 31, 2014 23:36
@pleabargain
Copy link

git 25Apr
running Lorenz Differential Equations

I get this error:

File "", line 12
def lorenz_deriv((x, y, z), t0, sigma=sigma, beta=beta, rho=rho):
^
SyntaxError: invalid syntax

@takluyver
Copy link
Member

@pleabargain : Yep, that syntax was dropped for Python 3. Do you want to open a new issue for it?

@pleabargain
Copy link

Well, I'm going through the notebooks and testing/playing with them. I've found that many of them have undocumented dependencies and don't work out of the box.

In the case of the Lorenz Differential Equations notebook is shipping with ipython2 but it doesn't work with python3. Maybe include a warning to the users that this example will NOT work OR include a different cell for pytho2.x users and python3.x users?

@takluyver
Copy link
Member

We mostly try to make the same examples work on Python 2 and Python 3 - this one must have just been missed.

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
another pass on Interact example notebooks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants