remove (almost) all mentions of pylab from our examples #5066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try: | ||
| import IPython.core.shellapp as mod; | ||
| for k in mod.InteractiveShellApp.pylab.values: | ||
| for k in mod.InteractiveShellApp.matplotlib.values: |
There was a problem hiding this comment.
I didn't see you change the name of any InteractiveShell attributes. Does this line assume that?
There was a problem hiding this comment.
This was done a while ago. Nothing to change in the actual code, just the examples.
|
Do we also want to rename our module and functions internally: Not nearly as big of a deal as it doesn't affect users. |
I suspect some folks reach into pylabtools for print_figure and/or figsize, so we would need to be careful about those. |
|
I think this looks good, merging. |
ellisonbg
added a commit
that referenced
this pull request
Feb 9, 2014
remove (almost) all mentions of pylab from our examples
keflavich
added a commit
to keflavich/runipy
that referenced
this pull request
Feb 19, 2014
The ipython devs discourage the use of pylab now (ipython/ipython#5066)
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
remove (almost) all mentions of pylab from our examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a quick scan through our examples, and removed any mention of pylab I could find and reasonably remove.