New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor keyboard handling #5076
Conversation
@ellisonbg I see #5053 has gone in, and you have added some tests for keyboard.js. Do you want to add some more now, or is this ready for review? |
This is ready for review. We can add more tests over time, but this is a On Fri, Feb 14, 2014 at 11:57 AM, Thomas Kluyver
Brian E. Granger |
Did you want to get the tests passing, first? |
Hmm, that is odd, this shouldn't have changed anything that would affect On Fri, Feb 14, 2014 at 10:36 PM, Min RK notifications@github.com wrote:
Brian E. Granger |
OK, rebased, tests passing and ready for final review. |
I thought I already merged this one...Merging now. |
Yes, I forgot about it myself - it needed rebasing. Thanks! On Mon, Mar 3, 2014 at 2:54 PM, Min RK notifications@github.com wrote:
Brian E. Granger |
Refactor keyboard handling
Fixes #4886
This creates a new JS module as
base/keyboard.js
exposed asIPython.keyboard
for all of our keyboard handling. This is meant to replace the keyboard related stuff inIPython.utils
. But the removal of the old stuff will come later once we have better tests in place. This should wait for #5053 so tests ofkeyboard.js
can be added.