trust cells with no output #5087
Conversation
It's outputs we don't trust, so if there are no outputs there's nothing to distrust.
|
This looks reasonable. In testing this, I think we want to also trust cells with only stream stdout and stderr. Those currently cause a notebook to be untrusted until you rerun them, but no visual indication of the fact that they are untrusted, like the kind that comes with rich output, since the way we display them is safe. Should we do that here or as a separate PR? |
not just cells with no output
|
Good idea. This PR now matches more closely the javascript logic - safe (not parsed-safe, but always-safe keys) outputs will not affect the trust result. So you only need to re-run the actual untrusted outputs for the notebook to become signed. |
| @@ -40,17 +40,7 @@ | |||
| "cell_type": "code", | |||
| "collapsed": false, | |||
| "input": [ | |||
| "next_paragraph = \"\"\"\n", | |||
| "Aenean vitae diam consectetur, tempus arcu quis, ultricies urna. Vivamus venenatis sem \n", | |||
| "quis orci condimentum, sed feugiat dui porta.\n", | |||
There was a problem hiding this comment.
Did you write this hilarity? Google tells me it translates to "Just remember the main platform of life, the time with the bow person who, in a glass jar. Customizable settings to improve the lot of the average, but the overall performance"
There was a problem hiding this comment.
|
ok, tested it, works great, thanks @minrk 👍 merging |
trust cells with no output
It's outputs we don't trust, so if there are no outputs there's nothing to distrust.