Remove legacy azure nbmanager #5089
Conversation
|
I'm 👍 for removing broken obsolete code, pinging @ellisonbg who wrote this file, though |
|
Kyle and I discussed this one at the dev meeting last month, so I'm +1 here. @rgbkrk you will also want to remove the remaining references to azure in docs and iptest. |
|
Took care of the other references. I was tempted to write something about alternative notebook stores in https://github.com/ipython/ipython/pull/5089/files#diff-db7782c1108f2a401996ba90ee666c43R137, but felt like I'd be self promoting bookstore. |
|
Kyle, can you also add an I support including pointers to other stores - a reference to your bookstore as well as http://github.com/khinsen/simple_notebook_manager would be handy to have in the docs |
|
Alright. I've added the removal doc and added some pointers on alternative notebook stores. Pinging @khinsen, the author of the simple notebook manager to see what he thinks of the text. |
| @@ -0,0 +1 @@ | |||
| * The Azure notebook manager is not compatible with the current notebook storage scheme | |||
There was a problem hiding this comment.
This should actually say that it was removed - it will go into the release notes for 2.0.
| c.AzureNotebookManager.account_key = u'paste_your_account_key_here' | ||
| c.AzureNotebookManager.container = u'notebooks' | ||
| Writing a notebook manager is as simple as extending the base class | ||
| :class:`NotebookManager`. The simple_notebook_manager_ provides a great example |
There was a problem hiding this comment.
I guess the trailing underscore after simple_notebook_manager shouldn't be there, unless that's a reST feature.
There was a problem hiding this comment.
That's a rest feature - it connects it to the link, defined below with a leading underscore. Not the most beautiful part of the rst syntax.
|
I'm sitting next to @ellisonbg, and he says 👍. Merging. |
Remove legacy azure nbmanager
This deletes the code for the azure notebook manager, which no longer works with the current notebook management scheme (files, not UUIDs)
I started migrating bookstore to use libcloud to make the cloud based storage of notebooks abstracted across providers. First step there is getting it to work with the old 1.x releases, then getting it to work with 2.x.