don't use combine option on ucs package #5133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caused problems with unicode. It seems f9c32fc was actually the right fix for the original error, not faf51b858a8c5757944822ee1d75c11367e994f. closes ipython#5129
|
pinging @Carreau who originally reported the bug to see if this fixes it for him. |
|
I haven't actually fired up IPython in a week. I'll Try to have a look, but no promises. Envoyé de mon iPhone
|
|
Works for me. merging ... (yeah first use of IPython in a week !) |
Carreau
added a commit
that referenced
this pull request
Feb 20, 2014
Don't use combine option on ucs package **never** use combine when mixing ascii and non-ascii chars or all the non-ascii chars will be rendered after the ascii one have been.
|
Arg, now I'm seeing the original failure in test_filename_accent_pdf: |
|
The newly revitalized error should be fixed¹ by #5194. ¹ for sad values of fixed. |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Don't use combine option on ucs package **never** use combine when mixing ascii and non-ascii chars or all the non-ascii chars will be rendered after the ascii one have been.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused problems with unicode.
It seems f9c32fc was actually the right fix for the original error, not faf51b858a8c5757944822ee1d75c11367e994f.
closes #5129