set default value from signature defaults in interact #5136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If available, use the default value from the signature for the initial condition, when using range/choice abbreviations. Not affected: - single-value abbreviations (`@interact(a=5)` sets `a=5`) - explicit Widgets
|
This works perfect for me, thank you! |
|
implementation looks sound, and the tests are passing. I'll check again at my desk tomorrow and then merge. |
| try: | ||
| widget.value = default | ||
| except TraitError: | ||
| # warn? |
There was a problem hiding this comment.
yes... I think it would be good to have an advice here...
|
LGTM 👍 |
|
We should also handle the case where the abbrev is a dict and add a test for that. |
both valid and invalid
|
dict case is tested, and a bug revealed in selection widgets is fixed as a result. |
before raising otherwise, invalid values were still accepted
| # Now build the widgets from the abbreviations. | ||
| kwargs_widgets.extend(_widgets_from_abbreviations(new_kwargs)) | ||
| kwargs_widgets.extend(_widgets_from_abbreviations(sorted(kwargs.items(), key = lambda x: x[0]))) |
There was a problem hiding this comment.
Why remove the sorting? Is the idea to follow the order of arguments defined in the function itself?
There was a problem hiding this comment.
It's not removing the sorting, it's removing the line altogether. This line did nothing because kwargs is always empty.
|
Looks good merging. |
ellisonbg
added a commit
that referenced
this pull request
Feb 22, 2014
set default value from signature defaults in interact
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
set default value from signature defaults in interact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If available, use the default value from the signature for the initial condition, when using range/choice abbreviations.
Not affected:
@interact(a=5)setsa=5)as proposed in #5134