log refusal to serve hidden directories #5158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, with this PR, we now log the refusal to serve hidden directories, but continues to serve 404 to the user as before. The log message appears right above the 404 that it causes. |
|
Hmm, I don't see how your changes could cause it, but there is a test failure on travis. I have restarted the tests, but this one is weird (not with the JS tests) and probably worth looking into. |
|
looks like a real error on my part, fix incoming |
is_hidden expects the file to actually exist, so I've rearranged the logic such that is_hidden is called only after it's clear that the file exists.
|
Ok, test suite passes now. |
|
Looks good, thanks. |
ellisonbg
added a commit
that referenced
this pull request
Mar 4, 2014
log refusal to serve hidden directories
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
log refusal to serve hidden directories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR originally addressed #5157, and was titled "serve hidden directories when explicitly requested".
Now it simply logs the refusal to serve hidden directories, but continues to serve 404 to the user as before.